Dotnet list package --vulnerable uses AuditSources
#6237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nigusu-Allehu
force-pushed
the
dev-nyenework-dlp-auditsources
branch
from
cb0febb to
8d2c6eb
Compare
jeffkl
reviewed
Jan 28, 2025
.../NuGet.CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommand.cs
Show resolved
Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Show resolved
Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
nkolev92
reviewed
Jan 28, 2025
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/ListPackageTests.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/ListPackageTests.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/ListPackageTests.cs
Outdated
Show resolved
Hide resolved
jebriede
reviewed
Jan 28, 2025
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
Nigusu-Allehu
force-pushed
the
dev-nyenework-dlp-auditsources
branch
from
9e32cfa to
8a89814
Compare
jeffkl
previously approved these changes
Jan 29, 2025
Nigusu-Allehu
force-pushed
the
dev-nyenework-dlp-auditsources
branch
from
8a89814 to
c04b00f
Compare
nkolev92
reviewed
Jan 31, 2025
.../NuGet.CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommand.cs
Outdated
Show resolved
Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/ListPackageTests.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/ListPackageTests.cs
Outdated
Show resolved
Hide resolved
nkolev92
reviewed
Feb 5, 2025
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
....CommandLine.XPlat/Commands/PackageReferenceCommands/ListPackage/ListPackageCommandRunner.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.CommandLine.XPlat/ListPackage/ListPackageJsonRenderer.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.FuncTests/NuGet.XPlat.FuncTest/NuGet.XPlat.FuncTest.csproj
Show resolved
Hide resolved
jeffkl
previously approved these changes
Feb 5, 2025
jeffkl
approved these changes
Feb 7, 2025
nkolev92
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13767
Description
Design Spec: https://github.com/NuGet/Home/blob/dev/accepted/2024/Dotnet-list-package-vulnerable-uses-auditsources.md
This PR updates
dotnet list package --vulnerableto use user configured<AuditSources>.Currently, the command only looks into
<PackageSources>to load vulnerability data. However, with the introduction of NuGet Audit, other commands now support<AuditSources>to specify vulnerability data sources. This PR makes suredotnet list package --vulnerableis also up to date and supports<AuditSources>In order to do a manual test, I specified a package that has only one vulnerability data source. That source is only specified as an Audit source. This is what running
dotnet list package --vulnerableresults in before and after this PRBefore
After
PR Checklist
dotnet list package --vulnerableuses AuditSources Home#14021